Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect NODE_PATH env variable #16304

Closed
wants to merge 2 commits into from

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
bugfix

Porting changes from webpack/webpack-cli#3411

Reference webpack/webpack-cli#3355

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run prettier 👍

@webpack-bot
Copy link
Contributor

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.

@snitin315 snitin315 closed this Mar 11, 2023
@snitin315 snitin315 deleted the fix-node-path branch March 11, 2023 05:44
@snitin315 snitin315 restored the fix-node-path branch March 11, 2023 05:44
@snitin315
Copy link
Member Author

@alexander-akait rebased in #16808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants