I want to resolve#16045 , I made relevant changes mentioned in the issue. let me know if any additional changes are required #16122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
For maintainers only:
|
alexander-akait
approved these changes
Aug 10, 2022
|
hey, are any more changes required? |
|
All is fine 👍 |
|
Oh, then when will it be merged? |
|
In near future |
|
hey, can you please add hacktoberfest tag and merge the PR. Thank you! |
|
Thanks |
|
No problem!! I'll appreciate more such beginner friendly issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #16045
I implemented the issue and solution mentioned in the issue
What kind of change does this PR introduce?
a bugfix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?