Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add createRequire support #15579

Merged
merged 5 commits into from May 11, 2022
Merged

add createRequire support #15579

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34c4edc
add createRequire support
vankop Mar 23, 2022
ee911c6
add createRequire javascript parser option
vankop Mar 28, 2022
3b6328c
Merge branch 'main' into support-create-require
vankop Mar 28, 2022
8df5134
support context
vankop Mar 28, 2022
c82dc1e
Merge branch 'main' into support-create-require
vankop May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions declarations/WebpackOptions.d.ts
View file
Open in desktop
Expand Up @@ -2929,6 +2929,10 @@ export interface JavascriptParserOptions {
* Enable/disable parsing of magic comments in CommonJs syntax.
*/
commonjsMagicComments?: boolean;
/**
* Enable/disable parsing "import { createRequire } from "module"" and evaluating createRequire().
*/
createRequire?: boolean | string;
/**
* Specifies the behavior of invalid export names in "import ... from ..." and "export ... from ...".
*/
Expand Down
13 changes: 9 additions & 4 deletions lib/config/defaults.js
View file
Open in desktop
Expand Up @@ -190,7 +190,8 @@ const applyWebpackOptionsDefaults = options => {
syncWebAssembly: options.experiments.syncWebAssembly,
asyncWebAssembly: options.experiments.asyncWebAssembly,
css: options.experiments.css,
futureDefaults
futureDefaults,
isNode: targetProperties && targetProperties.node === true
});

applyOutputDefaults(options.output, {
Expand Down Expand Up @@ -451,11 +452,12 @@ const applySnapshotDefaults = (snapshot, { production, futureDefaults }) => {
* @param {JavascriptParserOptions} parserOptions parser options
* @param {Object} options options
* @param {boolean} options.futureDefaults is future defaults enabled
* @param {boolean} options.isNode is node target platform
* @returns {void}
*/
const applyJavascriptParserOptionsDefaults = (
parserOptions,
{ futureDefaults }
{ futureDefaults, isNode }
) => {
D(parserOptions, "unknownContextRequest", ".");
D(parserOptions, "unknownContextRegExp", false);
Expand All @@ -470,6 +472,7 @@ const applyJavascriptParserOptionsDefaults = (
D(parserOptions, "wrappedContextCritical", false);
D(parserOptions, "strictThisContextOnImports", false);
D(parserOptions, "importMeta", true);
D(parserOptions, "createRequire", isNode);
if (futureDefaults) D(parserOptions, "exportsPresence", "error");
};

Expand All @@ -481,11 +484,12 @@ const applyJavascriptParserOptionsDefaults = (
* @param {boolean} options.asyncWebAssembly is asyncWebAssembly enabled
* @param {CssExperimentOptions} options.css is css enabled
* @param {boolean} options.futureDefaults is future defaults enabled
* @param {boolean} options.isNode is node target platform
* @returns {void}
*/
const applyModuleDefaults = (
module,
{ cache, syncWebAssembly, asyncWebAssembly, css, futureDefaults }
{ cache, syncWebAssembly, asyncWebAssembly, css, futureDefaults, isNode }
) => {
if (cache) {
D(module, "unsafeCache", module => {
Expand All @@ -504,7 +508,8 @@ const applyModuleDefaults = (

F(module.parser, "javascript", () => ({}));
applyJavascriptParserOptionsDefaults(module.parser.javascript, {
futureDefaults
futureDefaults,
isNode
});

A(module, "defaultRules", () => {
Expand Down