Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hrm error when works with Module federation #15542

Merged
merged 7 commits into from
Apr 4, 2022
Merged

fix hrm error when works with Module federation #15542

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7264d0
fix(container): __webpack_modules__[id] => __webpack_require__.m[id]
wangjinyang Mar 11, 2022
2d390a2
Merge remote-tracking branch 'upstream/main'
wangjinyang Mar 17, 2022
69a0c52
Update lib/container/RemoteRuntimeModule.js
wangjinyang Apr 1, 2022
5afbaf6
Update lib/container/RemoteRuntimeModule.js
wangjinyang Apr 1, 2022
53d5a59
Merge remote-tracking branch 'origin/bugfix/mf-hmr-error' into bugfix…
wangjinyang Apr 2, 2022
111a7b7
Merge remote-tracking branch 'upstream/main' into bugfix/mf-hmr-error
wangjinyang Apr 2, 2022
ceed937
fix: pretty-lint error "RuntimeGlobals.moduleFactories"
wangjinyang Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/container/RemoteRuntimeModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ class RemoteRuntimeModule extends RuntimeModule {
Template.indent(
`error.message += '\\nwhile loading "' + data[1] + '" from ' + data[2];`
),
`__webpack_modules__[id] = ${runtimeTemplate.basicFunction("", [
"throw error;"
])}`,
`${
RuntimeGlobals.moduleFactories
}[id] = ${runtimeTemplate.basicFunction("", ["throw error;"])}`,
"data.p = 0;"
])};`,
`var handleFunction = ${runtimeTemplate.basicFunction(
Expand Down Expand Up @@ -111,10 +111,11 @@ class RemoteRuntimeModule extends RuntimeModule {
)};`,
`var onFactory = ${runtimeTemplate.basicFunction("factory", [
"data.p = 1;",
`__webpack_modules__[id] = ${runtimeTemplate.basicFunction(
"module",
["module.exports = factory();"]
)}`
`${
RuntimeGlobals.moduleFactories
}[id] = ${runtimeTemplate.basicFunction("module", [
"module.exports = factory();"
])}`
])};`,
"handleFunction(__webpack_require__, data[2], 0, 0, onExternal, 1);"
])});`
Expand Down