-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate compiler options in multicompiler mode #15460
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
076bc4a
validate compiler options in multicompiler mode
vankop d00aa38
Merge branch 'main' into feature/issue-14843
vankop 513126d
add default cache names in multicompiler mode
vankop 5203fbf
add default cache names in multicompiler mode
vankop 24f8a3a
fix warnings
vankop 0a15026
Merge branch 'main' into feature/issue-14843
vankop a52e328
more tests
vankop 677dc53
refactor: logic
alexander-akait 2addbcf
refactor: name
alexander-akait 637bdc1
refactor: code
alexander-akait c276484
test: fix
alexander-akait ca4e22c
skip tests for basic test run
vankop File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
test/configCases/cache-filesystem/multicompiler-mode-cache-1/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
it("should build", () => {}); |
23 changes: 23 additions & 0 deletions
23
test/configCases/cache-filesystem/multicompiler-mode-cache-1/webpack.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
"use strict"; | ||
|
||
// default settings. should just work | ||
|
||
/** @type {import("../../../../").Configuration} */ | ||
module.exports = [ | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
type: "filesystem", | ||
name: "name2" | ||
} | ||
}, | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
type: "filesystem", | ||
name: "name1" | ||
} | ||
} | ||
]; |
1 change: 1 addition & 0 deletions
1
test/configCases/cache-filesystem/multicompiler-mode-cache-2/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
it("should build", () => {}); |
29 changes: 29 additions & 0 deletions
29
test/configCases/cache-filesystem/multicompiler-mode-cache-2/webpack.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
"use strict"; | ||
|
||
// no cache names | ||
|
||
/** @type {import("../../../../").Configuration} */ | ||
module.exports = [ | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
type: "filesystem" | ||
} | ||
}, | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
type: "filesystem" | ||
} | ||
}, | ||
{ | ||
name: "3rd compiler", | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
type: "filesystem" | ||
} | ||
} | ||
]; |
1 change: 1 addition & 0 deletions
1
test/configCases/cache-filesystem/multicompiler-mode-cache-3/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
it("should build", () => {}); |
4 changes: 4 additions & 0 deletions
4
test/configCases/cache-filesystem/multicompiler-mode-cache-3/warnings.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = [ | ||
/Please set unique "cache\.name" option/, | ||
/Compiler with name "3rd compiler" doesn't use unique cache name/ | ||
]; |
32 changes: 32 additions & 0 deletions
32
test/configCases/cache-filesystem/multicompiler-mode-cache-3/webpack.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
"use strict"; | ||
|
||
// with explicit cache names | ||
|
||
/** @type {import("../../../../").Configuration} */ | ||
module.exports = [ | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
name: "filesystem", | ||
type: "filesystem" | ||
} | ||
}, | ||
{ | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
name: "filesystem", | ||
type: "filesystem" | ||
} | ||
}, | ||
{ | ||
name: "3rd compiler", | ||
mode: "production", | ||
entry: "./index", | ||
cache: { | ||
name: "filesystem", | ||
type: "filesystem" | ||
} | ||
} | ||
]; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test where we have two
true
values and so don't have any problems