Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fix to module federation to stop ignoring the singleton flag when requiredVersion is false #14884

Merged
merged 2 commits into from Dec 3, 2021
Merged

Proposed fix to module federation to stop ignoring the singleton flag when requiredVersion is false #14884

merged 2 commits into from Dec 3, 2021

Commits on Dec 2, 2021

  1. Proposed fix to module federation to stop ignoring the singleton flag… 

    … when requiredVersion is false
    @colacadstink
    colacadstink committed Dec 2, 2021
    Copy the full SHA
    92e3730 View commit details
    Browse the repository at this point in the history

  2. Added testing for new singleton logic (and caught a typo in the proce… 

    …ss!)
    @colacadstink
    colacadstink committed Dec 2, 2021
    Copy the full SHA
    bbe72b3 View commit details
    Browse the repository at this point in the history