Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regexp in DefaultStatsPrinterPlugin.js #14679

Merged
merged 1 commit into from Nov 8, 2021
Merged

fix regexp in DefaultStatsPrinterPlugin.js #14679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/stats/DefaultStatsPrinterPlugin.js
View file
Open in desktop
Expand Up @@ -1160,7 +1160,7 @@ const AVAILABLE_FORMATS = {
},
{ regExp: /(\(module has no exports\))/g, format: red },
{ regExp: /\(possible exports: (.+)\)/g, format: green },
{ regExp: /\s*(.+ doesn't exist)/g, format: red },
{ regExp: /\s*([^\s].* doesn't exist)/g, format: red },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vankop make sense to look at other .+ places

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also small test to avoid regressions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, at least for DefaultStatsPrinterPlugin.js

{ regExp: /('\w+' option has not been set)/g, format: red },
{
regExp: /(Emitted value instead of an instance of Error)/g,
Expand Down