Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix managed paths regexp handling #14537

Merged
merged 1 commit into from Oct 20, 2021
Merged

fix managed paths regexp handling #14537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/FileSystemInfo.js
View file
Open in desktop
Expand Up @@ -1988,7 +1988,7 @@ class FileSystemInfo {
for (const managedPath of this.managedPathsRegExps) {
const match = managedPath.exec(path);
if (match) {
const managedItem = getManagedItem(managedPath[1], path);
const managedItem = getManagedItem(match[1], path);
if (managedItem) {
managedItems.add(managedItem);
managedSet.add(path);
Expand Down Expand Up @@ -2962,7 +2962,7 @@ class FileSystemInfo {
for (const managedPath of this.managedPathsRegExps) {
const match = managedPath.exec(path);
if (match) {
const managedItem = getManagedItem(managedPath[1], path);
const managedItem = getManagedItem(match[1], path);
if (managedItem) {
// construct timestampHash from managed info
return this.managedItemQueue.add(managedItem, (err, info) => {
Expand Down
5 changes: 5 additions & 0 deletions test/configCases/managedPaths/futureDefaults/index.js
View file
Open in desktop
@@ -0,0 +1,5 @@
import value from "package";

it("should work", () => {
expect(value).toBe(42);
});
1 change: 1 addition & 0 deletions test/configCases/managedPaths/futureDefaults/node_modules/package/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test/configCases/managedPaths/futureDefaults/node_modules/package/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions test/configCases/managedPaths/futureDefaults/webpack.config.js
View file
Open in desktop
@@ -0,0 +1,6 @@
/** @type {import("../../../../").Configuration} */
module.exports = {
experiments: {
futureDefaults: true
}
};