Do not drop aggregated changes with resumed compilation #12881
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue with
suspend
andresume
flow of webpackWatching
(see #12882). The root cause of the issue is that watchpack instance is closed beforeaggregated
event is emitted (but after thechange
event). So aggregated changes are silently dropped.I've added the simplest test to demonstrate this but there are other code paths where the same underlying problem occurs.
The fix I've added so far is just a draft to demonstrate a possible solution. But ideally, we should patch
watchpack
to allow flushing pendingaggregated
events when closing the watcher.Can open a PR in watchpack with required changes. But first, want to make sure it is a viable solution.
What kind of change does this PR introduce?
A bugfix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
An anticipated fix should be backwards compatible.
What needs to be documented once your changes are merged?
This PR doesn't require documentation.
Fixes #12882