Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding types #12875

Closed
wants to merge 2 commits into from
Closed

Adding types #12875

wants to merge 2 commits into from

Conversation

Brian-McBride
Copy link
Contributor

What kind of change does this PR introduce?

This exposes more type definitions that are required for proper plugin development using Typescript.

Did you add tests for your changes?

There are no existing type tests. Added the types and ran the fix script as directed.

Does this PR introduce a breaking change?

Np, there are no type changes, just adding to the final export. The fix script changed the actual definition file. My edit was only to lib/index.js

What needs to be documented once your changes are merged?

Nothing. Typescript is self documentation.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

This was referenced Mar 11, 2021
Merged
Closed
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@alexander-akait
Copy link
Member

Can you accept CLA?

@Brian-McBride
Copy link
Contributor Author

Brian-McBride commented Mar 12, 2021 •
edited

Can you accept CLA?

I think I found the link to accept. Done.

@Brian-McBride
Copy link
Contributor Author

Weird that checks failed now.
6 files have unexpected coverage changes not visible in diff
Something is amiss with the codecov. Only 2 files were changed and that was exposing more types.
Seems odd that code coverage would drop in anyway.

@alexander-akait
Copy link
Member

Ignore this

@Brian-McBride Brian-McBride mentioned this pull request Mar 13, 2021
Closed
@Brian-McBride
Squashed commit of the following:
6c19c68 
commit 58dfda2
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Sun Mar 14 20:33:03 2021 +0100

    5.25.1

commit 3f2a269
Merge: e643b85 69218d4
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Sun Mar 14 20:32:00 2021 +0100

    Merge pull request webpack#12891 from webpack/bugfix/non-js-entry

    fix problem with startup of non-js initial chunks

commit 69218d4
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Sun Mar 14 19:54:34 2021 +0100

    fix problem with startup of non-js initial chunks

    fixes webpack#12880

commit e643b85
Merge: be352e8 61cc65c
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Fri Mar 12 14:47:23 2021 +0100

    Merge pull request webpack#12750 from RReverser/remove-worker-type-module

commit 61cc65c
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Fri Mar 12 12:09:02 2021 +0100

    improve parsing to handle non-literal options

commit e839494
Author: Ingvar Stepanyan <rreverser@google.com>
Date:   Mon Feb 22 17:43:38 2021 +0000

    Disallow type:module + importScripts in tests

commit ea2cdeb
Author: Ingvar Stepanyan <rreverser@google.com>
Date:   Mon Feb 22 16:25:24 2021 +0000

    Remove `type: 'module` from `new Worker` exprs

    Fixes webpack#12686.

commit be352e8
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Fri Mar 12 08:49:03 2021 +0100

    5.25.0

commit ab74839
Merge: bcf3cb2 c014665
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 21:00:05 2021 +0100

    Merge pull request webpack#12871 from webpack/feature/generate-asset

    add `emit` option for asset modules

commit bcf3cb2
Merge: 8ea0a6a 7245527
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 20:34:48 2021 +0100

    Merge pull request webpack#12872 from webpack/bugfix/ignore-asset-modules

    allow to define "ignored modules" per dependency

commit c014665
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 19:31:33 2021 +0100

    update cli snapshots

commit 7572217
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 18:44:41 2021 +0100

    add `emit` option for asset modules

    fixes webpack#12474

commit 7245527
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 15:04:53 2021 +0100

    allow to define "ignored modules" per dependency

    new URL() will use `"data:"` when ignore

commit 85a6eee
Author: Tobias Koppers <tobias.koppers@googlemail.com>
Date:   Thu Mar 11 16:41:19 2021 +0100

    move parser.filename back to generator.filename
alexander-akait
alexander-akait reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid changes in code

@cr0cK
Copy link

cr0cK commented Nov 26, 2021

Any chance to see this reviewed and merged?

@sokra sokra mentioned this pull request Nov 29, 2021
Merged
@sokra
Copy link
Member

sokra commented Nov 29, 2021

This PR is broken and I can't modify it. Closing in favor of #14855

@sokra sokra closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

Assignees
No one assigned
Labels
PR: conflict PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Brian-McBride @webpack-bot @alexander-akait @cr0cK @sokra