Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pnpm support for installing CLI #11945

Merged
merged 3 commits into from Nov 20, 2020
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Nov 7, 2020

What kind of change does this PR introduce?
Enhancement, feature

Refs webpack/webpack-cli#2040 (comment)

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315 snitin315 closed this Nov 7, 2020
@snitin315 snitin315 reopened this Nov 7, 2020
@snitin315 snitin315 closed this Nov 7, 2020
@snitin315 snitin315 reopened this Nov 7, 2020
bin/webpack.js Outdated Show resolved Hide resolved
bin/webpack.js Outdated Show resolved Hide resolved
bin/webpack.js Outdated Show resolved Hide resolved
bin/webpack.js Outdated Show resolved Hide resolved
bin/webpack.js Outdated Show resolved Hide resolved
bin/webpack.js Outdated Show resolved Hide resolved
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@webpack-bot
Copy link
Contributor

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra sokra merged commit 044173e into webpack:master Nov 20, 2020
@sokra
Copy link
Member

sokra commented Nov 20, 2020

Thanks

@snitin315 snitin315 deleted the feat/pnpm branch November 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants