Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11186
closes #10227
This PR aims to bump
acorn
so?.
,??
,4_2
,x ??= y
should not throw syntax error: It is part of ES2021.This PR does not backport evaluations support in #11221. I think it is good enough for webpack@4. To further optimize expression related to these new syntax features, please upgrade to webpack@5. But the bottom line here is that webpack@4 should not throw for ES2021 syntax, especially when webpack 5 is not released yet.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No. The acorn tests itself should be sufficient.
Does this PR introduce a breaking change?
Yes. See https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#700-2019-08-13 Though acorn v7 to v8 is not breaking webpack 4.
What needs to be documented once your changes are merged?
Nothing.