WIP: reorder entries such that first registered entry is exported module #11389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is explained here: webpack/webpack-dev-server#2692 (comment)
My idea is that the very first entry in the compilation should be the one that is exported, so that if a user or webpack-dev-server registers more entries later, those will not be exported when a user has a config like:
This would result in a breaking change which I thinks make sense, but it can be adjusted if others find this to be a problematic breaking change. Consider the config:
Current behavior:
entry2.js
is the exported module.With my changes:
entry1.js
is the exported module (This seems more intuitive to me, feel free to disagree)If we don't want this breaking change, then I can reorder the entry config again here:
webpack/lib/WebpackOptionsApply.js
Line 267 in 00634bb
So that the last entry is the one exported.
What kind of change does this PR introduce?
fix (related to webpack-dev-server)
Did you add tests for your changes?
Not yet
Does this PR introduce a breaking change?
Yes, ordering of entries internally in webpack
What needs to be documented once your changes are merged?
How webpack entries work when exporting as a module