add nullish coalescing support #11208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
sokra
force-pushed
the
feature/nullish-coalescing
branch
2 times, most recently
from
a8e1c0b
to
e8f224a
Compare
vankop
reviewed
Jul 20, 2020
vankop
reviewed
Jul 20, 2020
- add handleStrictEqualityComparison callback - add handleAbstractEqualityComparison callback - rework evaluateIdentifier interface - add tests
sokra
force-pushed
the
feature/nullish-coalescing
branch
from
e8f224a
to
c8aff62
Compare
|
LGTM at first look, I could take a look more carefully later. |
|
@aladdin-add This is PR that was split in two, you can see it from history 😄 |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
commented
Jul 22, 2020
vankop
reviewed
Jul 22, 2020
vankop
approved these changes
Jul 22, 2020
webpack-bot
added
PR: reviewed-approved
and removed
PR: unreviewed
PR: tests-needed
labels
|
The minimum test ratio has been reached. Thanks! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing