Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for #8293 #8338

Merged
merged 2 commits into from Nov 5, 2018
Merged

Bugfix for #8293 #8338

merged 2 commits into from Nov 5, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 5, 2018

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

FranckFreiburger and others added 2 commits November 5, 2018 14:02
@FranckFreiburger
test for #8293
dcd0d59
@sokra
replace prefix/postfix even when equal for wrapped context
babe736 
walk inner expressions in wrapped context
add tracking of inner expressions in wrapped BasicEvaluatedExpression
fixes #8293
closes ##8337
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@sokra sokra mentioned this pull request Nov 5, 2018
Closed
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit e2a2016 into master Nov 5, 2018
@sokra sokra deleted the bugfix/issue-8293 branch November 5, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @webpack-bot @FranckFreiburger