DefinePlugin regression

[FranckFreiburger]

Bug report

What is the current behavior?

DefinePlugin does not replace things in all situations.
I encounter this issue while upgrading from webpack v3.6.0 to v4.23.1

If the current behavior is a bug, please provide the steps to reproduce.

new webpack.DefinePlugin({
	NAME: 'foobar'
})

then:

import(`./${NAME}.yaml`)

expands to:

__webpack_require__("../mytest lazy recursive ^\\.\\/.*\\.yaml$")('./' + NAME + '.yaml')

that is not correct.

Other relevant information:
webpack version: 4.23.1
Node.js version: 10.10
Operating System: win7
Additional tools:

[ljqx]

I got some initial investigation:
ImportParserPlugin stops walk on its param when creating context, but it shouldn't.

Changing the return value to false should fix it.

I can try to send out a fix for it.

[sokra]

 new webpack.DefinePlugin({
-	NAME: 'foobar'
+	NAME: '"foobar"'
 })

[sokra]

hmm seems like to intentionally passed an expression. Than it seems to be a bug.

As workaround:

const name = NAME;
import(`./${name}.yaml`)

[FranckFreiburger]

Sorry for my ambiguous test, it should be:

new webpack.DefinePlugin({
	NAME: '"foobar"'
})

then:

var tmp = '';
import(`./${NAME}${tmp}.yaml`)

expands to:

var tmp = '';
__webpack_require__("../myTest lazy recursive ^\\.\\/foobar.*\\.yaml$")(`./${NAME}${tmp}.yaml`)

[sokra]

ah ok. That seem to be different.

[FranckFreiburger]

Yes, but in both situations, something is not properly expanded.

[FranckFreiburger]

@sokra, it seems that the problem is still present (in v4.25.0)
NAME is not replaced by "foobar" as expected:

__webpack_require__("../myTest lazy recursive ^\\.\\/foobar.*\\.yaml$")('./' + NAME + tmp + '.yaml')

[ljqx]

It works at my side, check https://github.com/ljqx/webpack-test-import-parser.

The fix only works for template string, it doesn't include fix for string concated by +. That needs another fix to work.

I can have a try.

[sokra]

I already have a fix. Sorry didn't read your comment.

[sokra]

#8338