Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize chunk graph algorithm #8242

Merged
merged 1 commit into from Oct 20, 2018
Merged

Optimize chunk graph algorithm #8242

merged 1 commit into from Oct 20, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 19, 2018

What kind of change does this PR introduce?
performance

Did you add tests for your changes?
existing tests

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@sokra
Copy link
Member Author

sokra commented Oct 19, 2018

#8126

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@MLoughry
Copy link
Contributor

I see ~12% shorter rebuild times in my repo. Definitely 👍

@sokra sokra merged commit 5165a90 into master Oct 20, 2018
@sokra
Copy link
Member Author

sokra commented Oct 20, 2018

Great

@sokra sokra deleted the perf/chunk-graph branch October 20, 2018 11:01
@sokra sokra mentioned this pull request Oct 23, 2018
Closed
@alexander-akait alexander-akait mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooflorent ooflorent ooflorent left review comments

Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sokra @webpack-bot @MLoughry @ooflorent