Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow banner to be placed as a footer #15617

Merged
merged 1 commit into from Apr 4, 2022
Merged

Conversation

DavidTanner
Copy link
Contributor

What kind of change does this PR introduce?

There is a plugin we are using for version 4 that does the same thing as BannerPlugin, but it could place the text at the bottom of the file instead of the top. This allows the BannerPlugin to place the banner either as a header or footer. No other changes

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No. The new flag defaults to falsy

What needs to be documented once your changes are merged?

The website will need to be updated here to reflect the new optional parameter footer

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DavidTanner / name: David Tanner (4f2adf9)

@webpack-bot
Copy link
Contributor

webpack-bot commented Apr 1, 2022

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit 05ebf5b into webpack:main Apr 4, 2022
@sokra
Copy link
Member

sokra commented Apr 4, 2022

Thanks

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants