Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins): add footer parameter for BannerPlugin #6094

Merged
merged 1 commit into from
Apr 16, 2022
Merged

docs(plugins): add footer parameter for BannerPlugin #6094

merged 1 commit into from
Apr 16, 2022

Conversation

DavidTanner
Copy link
Contributor

Fixes #6077

There is a plugin we are using for version 4 that does the same thing as BannerPlugin, but it could place the text at the bottom of the file instead of the top. This allows the BannerPlugin to place the banner either as a header or footer. No other changes.

BannerPlugin was updated by webpack/webpack#15617

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/DZ4Nsp315azaUoSJkxCpwWk3awUL
✅ Preview: https://webpack-js-org-git-fork-davidtanner-issue-6-bfbf76-webpack-docs.vercel.app

@snitin315 snitin315 changed the title Add new optional parameter docs(plugins): add footer parameter for BannerPlugin Apr 16, 2022
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 24b0f27 into webpack:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document webpack change: Allow banner to be placed as a footer
2 participants