Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support context in Dependency #15585

Merged
merged 2 commits into from Mar 28, 2022
Merged

support context in Dependency #15585

merged 2 commits into from Mar 28, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Mar 25, 2022 •
edited

What kind of change does this PR introduce?
refactoring/bugfix
fixes #15580

Did you add tests for your changes?
updated existing

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@vankop vankop closed this Mar 25, 2022
@vankop vankop reopened this Mar 25, 2022
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop force-pushed the refactor/support-context-in-dependency branch from 483e053 to b9cca71 Compare March 25, 2022 13:42
@vankop vankop closed this Mar 25, 2022
@vankop vankop reopened this Mar 25, 2022
@vankop vankop force-pushed the refactor/support-context-in-dependency branch from b9cca71 to 6b1e920 Compare March 25, 2022 13:50
@vankop vankop closed this Mar 25, 2022
@vankop vankop reopened this Mar 25, 2022
@vankop vankop force-pushed the refactor/support-context-in-dependency branch from 6b1e920 to cf5fc90 Compare March 25, 2022 14:02
sokra
sokra requested changes Mar 25, 2022
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Could you add the bug report as test case too?

@webpack-bot
Copy link
Contributor

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@vankop vankop force-pushed the refactor/support-context-in-dependency branch from a9e3aaa to 5605e53 Compare March 28, 2022 05:03
@sokra sokra merged commit 2c200d1 into main Mar 28, 2022
@sokra sokra deleted the refactor/support-context-in-dependency branch March 28, 2022 13:35
@sokra
Copy link
Member

sokra commented Mar 28, 2022

Thanks

@hong6316 hong6316 mentioned this pull request Jun 27, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.webpackContext doesn't work if requiring inside npm packages
3 participants
@vankop @webpack-bot @sokra