Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRO-6377: Fix security vulnerabilities #105

Merged
merged 5 commits into from
Jul 8, 2022
Merged

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Jun 24, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

For preventing malware issues, we need to update node modules that fix severity vulnerabilities.
But fixing enactjs/cli#290 without dev-utils' changes, enact pack --framework fails to compile.
(internal API changed: webpack/webpack#15585)
We need to sync modules' version between CLI and dev-utils

Resolution

Update the module to sync with CLI

  • "webpack": "5.73.0"

Additional Considerations

Pinning modules to follow WRO-7169

  • "core-js": "3.22.8"

update other dependencies that changed minor version.

Links

WRO-6377

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

@hong6316 hong6316 requested a review from MikyungKim June 24, 2022 09:21
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

@MikyungKim MikyungKim changed the title WRO-6377: fix security vulnerabilities WRO-6377: Fix security vulnerabilities Jul 1, 2022
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim MikyungKim merged commit 61f3fba into develop Jul 8, 2022
@MikyungKim MikyungKim deleted the feature/WRO-6377 branch July 8, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants