Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hrm error when works with Module federation #15542

Merged
merged 7 commits into from Apr 4, 2022
Merged

fix hrm error when works with Module federation #15542

merged 7 commits into from Apr 4, 2022

Conversation

wangjinyang
Copy link
Contributor

What kind of change does this PR introduce?
fixes #15534

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
no

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@wangjinyang wangjinyang changed the title Module federation Throw Error worked with HMR When Compile A Async Chunk fix hrm error when works with Module federation Mar 18, 2022
sokra
sokra requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Only a nitpick is to get the name of the property from the constants.

lib/container/RemoteRuntimeModule.js Outdated Show resolved Hide resolved
lib/container/RemoteRuntimeModule.js Outdated Show resolved Hide resolved
@wangjinyang @sokra
Update lib/container/RemoteRuntimeModule.js
69a0c52 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@webpack-bot
Copy link
Contributor

@wangjinyang Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra sokra merged commit 2a58ce7 into webpack:main Apr 4, 2022
@sokra
Copy link
Member

sokra commented Apr 4, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hrm throw error when works with Module federation
3 participants
@wangjinyang @webpack-bot @sokra