Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cache in BannerPlugin #15454

Merged
merged 1 commit into from Mar 3, 2022
Merged

use cache in BannerPlugin #15454

merged 1 commit into from Mar 3, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Mar 1, 2022 •
edited

What kind of change does this PR introduce?

fixes #15447
Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit 75383c9 into main Mar 3, 2022
@sokra sokra deleted the fix/issue-15447 branch March 3, 2022 08:09
@sokra
Copy link
Member

sokra commented Mar 3, 2022

Thanks

@Rezyan
Copy link

Rezyan commented Mar 3, 2022

@vankop Thanks for the PR, nice job!

@lforst lforst mentioned this pull request Apr 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BannerPlugin does not work as expected with watch: true and mode: 'development'
4 participants
@vankop @webpack-bot @sokra @Rezyan