feat(webpack): Add debug ID injection to the webpack plugin #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 7, 2023
| @@ -42,7 +42,8 @@ | |||
| "find-up": "5.0.0", | |||
| "glob": "9.3.2", | |||
| "magic-string": "0.27.0", | |||
| "unplugin": "1.0.1" | |||
| "unplugin": "1.0.1", | |||
| "webpack-sources": "^3.2.3" | |||
There was a problem hiding this comment.
m: should we hard pin? Also this doesn't change yarn.lock?
There was a problem hiding this comment.
good point. Added. The yarn lock didn't change because unplugin itself depended on the exact same version.
| return; | ||
| } | ||
|
|
||
| compilation.updateAsset(fileName, () => { |
There was a problem hiding this comment.
do we need to cache here? So we only inject once?
There was a problem hiding this comment.
Added the cache inspired by webpack/webpack#15454
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #191
Similar to #192, we now add debug ID injection to the Webpack plugin.
Note this needs tests. We will add them as a follow-up when we identified some quirks with the injection across all bundlers.