refactor: logic suggestions from code review

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
webpack · Nov 20, 2020 · fa7686c · fa7686c
1 parent e827f4f
commit fa7686c
Showing 1 changed file with 3 additions and 17 deletions.
diff --git a/bin/webpack.js b/bin/webpack.js
@@ -82,31 +82,17 @@ if (!cli.installed) {
 
 	console.error(notify);
 
-	const isNpm = fs.existsSync(path.resolve(process.cwd(), "package-lock.json"));
-
-	let isYarn = false;
-
-	if (!isNpm) {
-		isYarn = fs.existsSync(path.resolve(process.cwd(), "yarn.lock"));
-	}
-
-	let isPnpm = false;
-
-	if (!isYarn) {
-		isPnpm = fs.existsSync(path.resolve(process.cwd(), "pnpm-lock.yaml"));
-	}
-
 	let packageManager;
 
-	if (isYarn) {
+	if (fs.existsSync(path.resolve(process.cwd(), "yarn.lock"))) {
 		packageManager = "yarn";
-	} else if (isPnpm) {
+	} else if (fs.existsSync(path.resolve(process.cwd(), "pnpm-lock.yaml"))) {
 		packageManager = "pnpm";
 	} else {
 		packageManager = "npm";
 	}
 
-	const installOptions = [isYarn ? "add" : "install", "-D"];
+	const installOptions = [packageManager === "yarn" ? "add" : "install", "-D"];
 
 	console.error(
 		`We will use "${packageManager}" to install the CLI via "${packageManager} ${installOptions.join(