Merge pull request #12832 from webpack/bugfix/array-default-fallback

fix array expansion when using "..."
webpack · Mar 8, 2021 · c18b3c5 · c18b3c5
2 parents 9e7a293 + e63e733
commit c18b3c5
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/config/defaults.js b/lib/config/defaults.js
@@ -95,7 +95,7 @@ const A = (obj, prop, factory) => {
 			const item = value[i];
 			if (item === "...") {
 				if (newArray === undefined) {
-					newArray = i > 0 ? value.slice(0, i - 1) : [];
+					newArray = value.slice(0, i);
 					obj[prop] = /** @type {T[P]} */ (/** @type {unknown} */ (newArray));
 				}
 				const items = /** @type {any[]} */ (/** @type {unknown} */ (factory()));

diff --git a/test/Defaults.unittest.js b/test/Defaults.unittest.js
@@ -1703,4 +1703,24 @@ describe("Defaults", () => {
 			process.chdir(cwd);
 		}
 	);
+
+	test(
+		"array defaults",
+		{
+			output: {
+				enabledChunkLoadingTypes: ["require", "..."],
+				enabledWasmLoadingTypes: ["...", "async-node"]
+			}
+		},
+		e =>
+			e.toMatchInlineSnapshot(`
+			- Expected
+			+ Received
+
+			@@ ... @@
+			+       "require",
+			@@ ... @@
+			+       "async-node",
+		`)
+	);
 });