Merge pull request #13745 from webpack/bugfix/node-commonjs

fix #13744
webpack · Jul 8, 2021 · b171a15 · b171a15
2 parents 6a5766b + 9f84be0
commit b171a15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/ExternalModuleFactoryPlugin.js b/lib/ExternalModuleFactoryPlugin.js
@@ -12,7 +12,7 @@ const { resolveByProperty, cachedSetProperty } = require("./util/cleverMerge");
 /** @typedef {import("../declarations/WebpackOptions").Externals} Externals */
 /** @typedef {import("./NormalModuleFactory")} NormalModuleFactory */
 
-const UNSPECIFIED_EXTERNAL_TYPE_REGEXP = /^[a-z0-9]+ /;
+const UNSPECIFIED_EXTERNAL_TYPE_REGEXP = /^[a-z0-9-]+ /;
 const EMPTY_RESOLVE_OPTIONS = {};
 
 // TODO webpack 6 remove this

diff --git a/test/configCases/externals/externals-in-commons-chunk/webpack.config.js b/test/configCases/externals/externals-in-commons-chunk/webpack.config.js
@@ -5,7 +5,7 @@ module.exports = {
 		other: "./other"
 	},
 	externals: {
-		fs: "commonjs fs",
+		fs: "node-commonjs fs",
 		external: "1+2",
 		external2: "3+4",
 		external3: "5+6"