Merge pull request #14781 from tanhauhau/tanhauhau/add-validation-to-…

…remotes

feat: add validation to remotes

lib/util/extractUrlAndGlobal.js

@@ -11,5 +11,8 @@
  */
 module.exports = function extractUrlAndGlobal(urlAndGlobal) {
 	const index = urlAndGlobal.indexOf("@");
+	if (index <= 0 || index === urlAndGlobal.length - 1) {
+		throw new Error(`Invalid request "${urlAndGlobal}"`);
+	}
 	return [urlAndGlobal.substring(index + 1), urlAndGlobal.substring(0, index)];
 };

test/extractUrlAndGlobal.unittest.js

@@ -21,4 +21,15 @@ describe("extractUrlAndGlobal", () => {
 			"_"
 		]);
 	});
+	it("should throw error if starts with @", () => {
+		expect(() => extractUrlAndGlobal("@something")).toThrow();
+	});
+
+	it("should throw error if ends with @", () => {
+		expect(() => extractUrlAndGlobal("something@")).toThrow();
+	});
+
+	it("should throw error if do not have @", () => {
+		expect(() => extractUrlAndGlobal("something")).toThrow();
+	});
 });