Merge pull request #4737 from ndresx/lint-glob-errors-fix

Fix lint errors and normalize lint globs in package.json
webpack · Apr 18, 2017 · 8aa8a7b · 8aa8a7b
2 parents 25ae65e + aea0e64
commit 8aa8a7b
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -97,8 +97,8 @@
     "build:examples": "cd examples && node buildAll.js",
     "pretest": "npm run lint-files",
     "lint-files": "npm run lint && npm run beautify-lint",
-    "lint": "eslint lib bin hot buildin test/**/webpack.config.js test/binCases/**/test.js examples/**/webpack.config.js",
-    "beautify-lint": "beautify-lint 'lib/**/*.js' 'hot/**/*.js' 'bin/**/*.js' 'benchmark/*.js' 'test/*.js'",
+    "lint": "eslint lib bin hot buildin \"test/**/webpack.config.js\" \"test/binCases/**/test.js\" \"examples/**/webpack.config.js\"",
+    "beautify-lint": "beautify-lint \"lib/**/*.js\" \"hot/**/*.js\" \"bin/**/*.js\" \"benchmark/*.js\" \"test/*.js\"",
     "nsp": "nsp check --output summary",
     "benchmark": "mocha test/*.benchmark.js --harmony -R spec",
     "cover": "node --harmony ./node_modules/istanbul/lib/cli.js cover -x '**/*.runtime.js' node_modules/mocha/bin/_mocha -- test/*.test.js",

diff --git a/test/configCases/dll-plugin/1-use-dll/webpack.config.js b/test/configCases/dll-plugin/1-use-dll/webpack.config.js
@@ -3,7 +3,7 @@ var webpack = require("../../../../");
 module.exports = {
 	plugins: [
 		new webpack.DllReferencePlugin({
-			manifest: require("../../../js/config/dll-plugin/manifest0.json"),
+			manifest: require("../../../js/config/dll-plugin/manifest0.json"), // eslint-disable-line node/no-missing-require
 			name: "../0-create-dll/dll.js",
 			scope: "dll",
 			sourceType: "commonjs2",

diff --git a/test/configCases/dll-plugin/2-use-dll-without-scope/webpack.config.js b/test/configCases/dll-plugin/2-use-dll-without-scope/webpack.config.js
@@ -17,7 +17,7 @@ module.exports = {
 	},
 	plugins: [
 		new webpack.DllReferencePlugin({
-			manifest: require("../../../js/config/dll-plugin/manifest0.json"),
+			manifest: require("../../../js/config/dll-plugin/manifest0.json"), // eslint-disable-line node/no-missing-require
 			name: "../0-create-dll/dll.js",
 			context: path.resolve(__dirname, "../0-create-dll"),
 			sourceType: "commonjs2"

diff --git a/test/configCases/parsing/extended-api/webpack.config.js b/test/configCases/parsing/extended-api/webpack.config.js
@@ -1,8 +1,9 @@
-var webpack = require("../../../../");
+"use strict";
+const webpack = require("../../../../");
 
 module.exports = {
 	entry: {
-		other: './index'
+		other: "./index"
 	},
 	plugins: [
 		new webpack.ExtendedAPIPlugin()

diff --git a/test/statsCases/filter-warnings/webpack.config.js b/test/statsCases/filter-warnings/webpack.config.js
@@ -1,5 +1,5 @@
 "use strict";
-const webpack = require("webpack");
+const webpack = require("../../../");
 
 const baseConfig = {
 	entry: "./index",

diff --git a/test/statsCases/resolve-plugin-context/webpack.config.js b/test/statsCases/resolve-plugin-context/webpack.config.js
@@ -1,4 +1,4 @@
-const ResolvePackageFromRootPlugin = require("./ResolvePackageFromRootPlugin");
+var ResolvePackageFromRootPlugin = require("./ResolvePackageFromRootPlugin");
 
 module.exports = {
 	entry: "./index",

diff --git a/test/statsCases/warnings-uglifyjs/webpack.config.js b/test/statsCases/warnings-uglifyjs/webpack.config.js
@@ -1,4 +1,5 @@
-var webpack = require("webpack");
+"use strict";
+const webpack = require("../../../");
 
 module.exports = {
 	entry: "./index",