Merge pull request #13334 from webpack/bugfix/depend-on-runtime-async…

…-chunks

lib/Chunk.js

@@ -568,9 +568,15 @@ class Chunk {
 			Array.from(this.groupsIterable, g => new Set(g.chunks))
 		);
 
-		for (const chunkGroup of this.groupsIterable) {
+		const initialQueue = new Set(this.groupsIterable);
+
+		for (const chunkGroup of initialQueue) {
 			for (const child of chunkGroup.childrenIterable) {
-				queue.add(child);
+				if (child instanceof Entrypoint) {
+					initialQueue.add(child);
+				} else {
+					queue.add(child);
+				}
 			}
 		}
 

test/configCases/runtime/entries-in-runtime/async.js

@@ -0,0 +1 @@
+console.log("split");

test/configCases/runtime/entries-in-runtime/index.js

@@ -0,0 +1,11 @@
+import path from "path";
+import fs from "fs";
+
+it("should not have references to chunks of unrelated entrypoints in runtime", () => {
+	const content = fs.readFileSync(
+		path.resolve(__dirname, "runtime.js"),
+		"utf-8"
+	);
+	expect(content).not.toContain("other-entry");
+	expect(content).not.toContain("split");
+});

test/configCases/runtime/entries-in-runtime/other-entry.js

@@ -0,0 +1,2 @@
+import "./split";
+import("./async");

test/configCases/runtime/entries-in-runtime/split.js

@@ -0,0 +1 @@
+console.log("split");

test/configCases/runtime/entries-in-runtime/test.config.js

@@ -0,0 +1,5 @@
+module.exports = {
+	findBundle: function () {
+		return ["./runtime.js", "./main.js", "./first-entry.js"];
+	}
+};

test/configCases/runtime/entries-in-runtime/webpack.config.js

@@ -0,0 +1,39 @@
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	mode: "production",
+	entry: {
+		main: "./main",
+		"first-entry": {
+			dependOn: "main",
+			import: "./index"
+		},
+		"other-entry": {
+			dependOn: "main",
+			import: "./other-entry"
+		}
+	},
+	target: "web",
+	node: {
+		__dirname: false,
+		__filename: false
+	},
+	externalsPresets: {
+		node: true
+	},
+	output: {
+		filename: "[name].js"
+	},
+	optimization: {
+		runtimeChunk: "single",
+		splitChunks: {
+			cacheGroups: {
+				split: {
+					chunks: "all",
+					name: "split",
+					test: /split\.js$/,
+					enforce: true
+				}
+			}
+		}
+	}
+};