New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade eslint to latest version #3955
upgrade eslint to latest version #3955
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/8w7qwwyt0 |
CI failed when updating babel-eslint to v9, related issue babel/babel-eslint#799 |
After replacing require.resolve(dependency: String); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
3e82523
to
96b07b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice to see the eslint ignore comments gone :)
Thanks! |
I was trying to document
import.meta.url
introduced in webpack v5.0.0-beta.21 only to find that the current eslint (v4.19.1) we have threw error because theimport.meta
feature was added in eslint v7.2.0.This PR should upgrade eslint to the latest version so we can document more advanced JavaScript features that webpack supports.