Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade eslint to latest version #3955

Merged
merged 15 commits into from Sep 9, 2020

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Sep 5, 2020

I was trying to document import.meta.url introduced in webpack v5.0.0-beta.21 only to find that the current eslint (v4.19.1) we have threw error because the import.meta feature was added in eslint v7.2.0.

image

This PR should upgrade eslint to the latest version so we can document more advanced JavaScript features that webpack supports.

@vercel
Copy link

vercel bot commented Sep 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/8w7qwwyt0
✅ Preview: https://webpack-js-org-git-fork-chenxsan-feature-upgrade-eslint.webpack-docs.vercel.app

@chenxsan
Copy link
Member Author

chenxsan commented Sep 5, 2020

CI failed when updating babel-eslint to v9, related issue babel/babel-eslint#799

@chenxsan
Copy link
Member Author

chenxsan commented Sep 5, 2020

After replacing babel-eslint with @babel/eslint-parser, CI failed because we have some typescript typings in JavaScript code block https://github.com/webpack/webpack.js.org/blob/master/src/content/api/module-methods.md#require which is not valid JavaScript:

require.resolve(dependency: String);

@chenxsan
Copy link
Member Author

chenxsan commented Sep 5, 2020

Now we're able to use import.meta.url in JavaScript code block:

image

@chenxsan chenxsan marked this pull request as ready for review September 5, 2020 05:03
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@chenxsan chenxsan mentioned this pull request Sep 6, 2020
2 tasks
.babelrc Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 9, 2020 13:37 Inactive
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see the eslint ignore comments gone :)

@EugeneHlushko EugeneHlushko merged commit 65adf22 into webpack:master Sep 9, 2020
@EugeneHlushko
Copy link
Member

Thanks!

@chenxsan chenxsan deleted the feature/upgrade-eslint branch September 9, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants