Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DevServer): expand on devServer.openPage usage #3306

Merged
merged 6 commits into from Oct 23, 2019

Conversation

digitaljohn
Copy link

Changed documentation of devServer.openPage based on unreleased changes discussed here:
webpack/webpack-dev-server#2266

DO NOT MERGE until the aforementioned PR is integrated.

@digitaljohn digitaljohn changed the title docs(dev-server): expand on devServer.openPage usage docs(DevServer): expand on devServer.openPage usage Oct 1, 2019
@netlify
Copy link

netlify bot commented Oct 1, 2019

Preview is ready

Built with commit 141867a

https://deploy-preview-3306--webpackjsorg-netlify.netlify.com

@EugeneHlushko
Copy link
Member

We have draft PR feature enabled, you can use it next time for such placeholders

@montogeek
Copy link
Member

dev server change is released?

@digitaljohn
Copy link
Author

dev server change is released?

It appears it has been merged in but not released on NPM as of yet?

@digitaljohn
Copy link
Author

@montogeek The public version of webpack-dev-server now has this feature live.

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor change according to our writer's guide

src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
@digitaljohn
Copy link
Author

Looks good, just minor change according to our writer's guide

Good spot. Thanks.

@EugeneHlushko EugeneHlushko merged commit 244f74d into webpack:master Oct 23, 2019
@EugeneHlushko
Copy link
Member

Thanks!

@digitaljohn digitaljohn deleted the docs/multiple-openpage branch October 23, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants