Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump connect-history-api-fallback from 1.6.0 to 2.0.0 (#2716) #4501

Merged

Conversation

awwit
Copy link
Contributor

@awwit awwit commented Jun 27, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

I have added a new test to test the new behavior should perform HEAD request in same way as GET in test/e2e/history-api-fallback.test.js file.

Motivation / Use-Case

Link to issue: #2716

I faced the same problem, I need to solve it =)

Breaking Changes

The history-api-fallback now supports HEAD requests and handles them the same as GET.

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: awwit / name: Ignat Prokopovich (f20d131)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add small test case where we send HEAD request when connect-history-api-fallback is enabled, looks at our tests, it should be easy, thank you for the PR

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4501 (331dbe4) into master (73129c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4501   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files          16       16           
  Lines        1600     1600           
  Branches      604      604           
=======================================
  Hits         1477     1477           
  Misses        112      112           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73129c7...331dbe4. Read the comment docs.

@snitin315
Copy link
Member

You also need to create a snapshot for webpack 4

@awwit
Copy link
Contributor Author

awwit commented Jun 28, 2022

@snitin315 It looks like webpack-dev-server / Test - macos-latest - Node v12.x, Webpack latest (pull_request) task is stuck. I think it needs to be restarted if possible.

It's been running for almost 3 hours now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants