Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: debug #4144

Merged
merged 22 commits into from Jan 11, 2022
Merged

ci: debug #4144

merged 22 commits into from Jan 11, 2022

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

Try to fix ci again

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #4144 (1a2cad6) into master (75999bb) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4144      +/-   ##
==========================================
+ Coverage   92.15%   92.28%   +0.12%     
==========================================
  Files          14       14              
  Lines        1543     1543              
  Branches      590      590              
==========================================
+ Hits         1422     1424       +2     
+ Misses        112      110       -2     
  Partials        9        9              
Impacted Files Coverage Δ
lib/Server.js 93.73% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75999bb...1a2cad6. Read the comment docs.

@snitin315 snitin315 mentioned this pull request Jan 1, 2022
6 tasks
@alexander-akait
Copy link
Member Author

Weird, it happens only on macos, @snitin315 Can you check our tests locally again (maybe multiple times)?

@snitin315
Copy link
Member

I was unable to reproduce locally on macOS

@alexander-akait
Copy link
Member Author

I really don't understand... It is always random fail...

@alexander-akait
Copy link
Member Author

@snitin315 I just set jest.retryTimes(3) and now our tests are passed, I tried many things to debug and still haven't found why it happens sometimes, maybe migrate on playwire #2843 will solve the problem, let's postpone (we have an issue for this)

@snitin315
Copy link
Member

Yes. Let's migrate to playwright in near future.

@alexander-akait alexander-akait merged commit e535f25 into master Jan 11, 2022
@alexander-akait alexander-akait deleted the ci-debug branch January 11, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants