test: remove old and redundant test cases related to 3rd party code #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
snitin315
commented
Dec 22, 2021
| @@ -115,50 +104,4 @@ describe("Server", () => { | |||
| utilSpy.mockRestore(); | |||
| }); | |||
| }); | |||
|
|
|||
| // issue: https://github.com/webpack/webpack-dev-server/issues/1724 | |||
| describe("express.static.mime.types", () => { | |||
snitin315
commented
Dec 22, 2021
Comment on lines
-21
to
-25
| it("add decorateConnection", () => { | ||
| expect(typeof sockjs.Session.prototype.decorateConnection).toEqual( | ||
| "function" | ||
| ); | ||
| }); |
Codecov Report
@@ Coverage Diff @@
## master #4131 +/- ##
==========================================
+ Coverage 92.28% 92.41% +0.12%
==========================================
Files 14 14
Lines 1543 1543
Branches 590 590
==========================================
+ Hits 1424 1426 +2
+ Misses 110 108 -2
Partials 9 9
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
remove redundant test cases related to 3rd party code.
Breaking Changes
None
Additional Info
No