-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run tests on node 17.x in CI #3965
Conversation
need some tweaks webpack/webpack#14532 will update tomorrow |
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 14 14
Lines 1410 1410
Branches 519 519
=======================================
Hits 1306 1306
Misses 96 96
Partials 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a TODO here so as to remove workaround once resolved on webpack core.
EDIT:
Looks like node v17 and webpack 4 tests are stuck on ubuntu and macos.
Not sure why they're stuck maybe we need to skip node 17, webpack 4 combination 🤔 |
Same hashing algorithm issue 😞, check logs. |
webpack v4 should not be run on |
Yep let's skip the combination |
Seems like node 17 is stuck again 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move it to separate file helper file and name hashFunction: getHashFunction()
Got it |
d043160
to
887c539
Compare
For Bugs and Features; did you add new tests?
NA
Motivation / Use-Case
Node 17 is out so testing running dev-server tests in CI
Breaking Changes
Shouldn't
Additional Info