Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add examples for the client.reconnect option #3938

Merged
merged 1 commit into from Oct 12, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

add examples for the client.reconnect option.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #3938 (d5f729e) into master (ec78aee) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3938      +/-   ##
==========================================
+ Coverage   92.43%   92.58%   +0.14%     
==========================================
  Files          14       14              
  Lines        1362     1362              
  Branches      474      474              
==========================================
+ Hits         1259     1261       +2     
+ Misses         95       93       -2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 93.86% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec78aee...d5f729e. Read the comment docs.

@alexander-akait
Copy link
Member

@snitin315 Can you look at tests, maybe something wrong with ports, because we faced with this issue multiple times in near future

@alexander-akait
Copy link
Member

But maybe bug on puppuetter, we need decrease version

@snitin315
Copy link
Member Author

I will look into it, maybe we can migrate to playwright #2843

@alexander-akait
Copy link
Member

@snitin315 Yes, it will be great, feel free to try it, looks like API is mostly same

@snitin315 snitin315 merged commit 0153c69 into master Oct 12, 2021
@snitin315 snitin315 deleted the reconnect-example branch October 12, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants