fix: migrate entry injection to hooks #3424
Conversation
rishabh3112
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
|
Need to rebase. |
Codecov Report
@@ Coverage Diff @@
## master #3424 +/- ##
==========================================
- Coverage 95.24% 92.86% -2.39%
==========================================
Files 34 33 -1
Lines 1326 1317 -9
Branches 392 405 +13
==========================================
- Hits 1263 1223 -40
- Misses 59 85 +26
- Partials 4 9 +5
Continue to review full report at Codecov.
|
|
Need review 😃 |
| }).apply(compiler); | ||
| } | ||
| // Register Entry Dependency in Factory | ||
| const EntryDependency = require('webpack/lib/dependencies/EntryDependency'); |
There was a problem hiding this comment.
Avoid using this, webpack should public export this
There was a problem hiding this comment.
Should I send PR to webpack then?
rishabh3112
force-pushed
the
fix/migrate-to-hook
branch
from
30eaf1b
to
e1daeff
Compare
|
Note this is no longer needed as of #3467. |
|
Closing this PR. |
For Bugs and Features; did you add new tests?
Shouldn't require change
Motivation / Use-Case
/cc @alexander-akait
Helps fixing #3351
Breaking Changes
No
Additional Info
No