Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): don't crash on setupExitSignals(undefined) #2507

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix(server): don't crash on setupExitSignals(undefined) #2507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils/setupExitSignals.js
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ const signals = ['SIGINT', 'SIGTERM'];
function setupExitSignals(serverData) {
signals.forEach((signal) => {
process.on(signal, () => {
if (serverData.server) {
if (serverData && serverData.server) {
serverData.server.close(() => {
// eslint-disable-next-line no-process-exit
process.exit();
Expand Down
10 changes: 10 additions & 0 deletions test/server/utils/setupExitSignals.test.js
View file
Open in desktop
Expand Up @@ -25,6 +25,16 @@ describe('setupExitSignals', () => {
});

signals.forEach((signal) => {
it(`should exit process (${signal}, serverData never defined`, (done) => {
// eslint-disable-next-line no-undefined
setupExitSignals(undefined);
process.emit(signal);
setTimeout(() => {
expect(exitSpy.mock.calls.length).toEqual(1);
done();
}, 1000);
});

it(`should exit process (${signal}, server never defined)`, (done) => {
setupExitSignals({
server: null,
Expand Down