Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): replace include.toBeTruthy with toContain #2324

Merged
merged 1 commit into from Nov 22, 2019

Conversation

nougad
Copy link
Contributor

@nougad nougad commented Nov 21, 2019

For better test output.

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

Motivation / Use-Case

follow up from #2303

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #2324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2324   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          34       34           
  Lines        1284     1284           
  Branches      366      366           
=======================================
  Hits         1206     1206           
  Misses         77       77           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbda40...36c3c07. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@alexander-akait
Copy link
Member

Merging and ignore audit problem, let's update package.json in future

@alexander-akait alexander-akait merged commit d85d5b5 into webpack:master Nov 22, 2019
@alexander-akait
Copy link
Member

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants