Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selfsigned package with updated node-forge #2268

Closed
wants to merge 1 commit into from

Conversation

Dalimil
Copy link

@Dalimil Dalimil commented Oct 1, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

This updates selfsigned package to 1.10.7, which has an updated version of node-forge (0.8.2 -> 0.9.0). The old version of node-forge had security issues.

Breaking Changes

Additional Info

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dalimil Hajek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@alexander-akait
Copy link
Member

We already have PR #2267 😄

@Dalimil
Copy link
Author

Dalimil commented Oct 1, 2019

@evilebottnawi ah ok, didn't realize. sorry

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #2268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2268   +/-   ##
======================================
  Coverage    93.9%   93.9%           
======================================
  Files          34      34           
  Lines        1280    1280           
  Branches      368     368           
======================================
  Hits         1202    1202           
  Misses         71      71           
  Partials        7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8414d...1a5324e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants