Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scriptHost fix #2246

Merged
merged 3 commits into from Sep 16, 2019
Merged

scriptHost fix #2246

merged 3 commits into from Sep 16, 2019

Commits on Sep 12, 2019

  1. fix: fatal error when current JS is not inside script tag 

    * for example when html-webpack-inline-source-plugin is used, the JS is inlined in HTML in script tag. So in this case document.currentScript.getAttribute('src') is undefined
* undefined cannot be used as string with method replace. This cause a fatal error and crash app
    @misak113 @knagaitsev
    misak113 authored and knagaitsev committed Sep 12, 2019
    Copy the full SHA
    12c61eb View commit details
    Browse the repository at this point in the history

  2. test(client): update snapshot

    @knagaitsev
    knagaitsev committed Sep 12, 2019
    Copy the full SHA
    e837a95 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Merge branch 'master' into scripthost-fix

    @hiroppy
    hiroppy committed Sep 13, 2019
    Copy the full SHA
    28b63a8 View commit details
    Browse the repository at this point in the history