Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fatal error when current JS is not inside script tag #2229

Closed
wants to merge 1 commit into from
Closed

fix: fatal error when current JS is not inside script tag #2229

wants to merge 1 commit into from

Commits on Aug 27, 2019

  1. fix: fatal error when current JS is not inside script tag 

    * for example when html-webpack-inline-source-plugin is used, the JS is inlined in HTML in script tag. So in this case document.currentScript.getAttribute('src') is undefined
* undefined cannot be used as string with method replace. This cause a fatal error and crash app
    @misak113
    misak113 committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    b488304 View commit details
    Browse the repository at this point in the history