Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor to eliminate code redundancy #2120

Merged
merged 3 commits into from Jul 30, 2019

Conversation

jamesgeorge007
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

To eliminate redundanct code resulting in much concise code-base.

Breaking Changes

N/A

Additional Info

N/A

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #2120 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          33       33           
  Lines        1265     1265           
  Branches      361      363    +2     
=======================================
  Hits         1188     1188           
  Misses         71       71           
  Partials        6        6
Impacted Files Coverage Δ
lib/Server.js 97.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbf229...79790d7. Read the comment docs.

@knagaitsev
Copy link
Collaborator

@jamesgeorge007 Good idea, but this may be unnecessary since serverMode and clientMode will be removed soon in favor of a single transportMode option as explained here: #1860 (comment). Still, it can't hurt to have this while these options are still around.

@hiroppy
Copy link
Member

hiroppy commented Jul 15, 2019

Yes, I think it is better.

@hiroppy
Copy link
Member

hiroppy commented Jul 15, 2019

Sorry, I misread it. I wanna wait for changing transportMode because it'll be merge shortly.

lib/Server.js Outdated Show resolved Hide resolved
@knagaitsev
Copy link
Collaborator

@jamesgeorge007 I suggest you remove the serverMode/clientMode changes since #2116 will likely be merged shortly and there will be more changes to come for transportMode default setting. Keep the proxyConfig changes though.

@alexander-akait
Copy link
Member

Need fix problem with lint

@jamesgeorge007
Copy link
Member Author

@evilebottnawi It seems that everything's fine now 🤔

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroppy
Copy link
Member

hiroppy commented Jul 30, 2019

I don't know this change is needed.

@alexander-akait alexander-akait merged commit 18edd18 into webpack:master Jul 30, 2019
@alexander-akait
Copy link
Member

Just less code 😄

@jamesgeorge007 jamesgeorge007 deleted the feat/minor-refactor branch July 30, 2019 09:02
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants