Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(travis): Node 11 (on OS X) crashes, use 10 for now #1588

Merged
merged 1 commit into from Dec 4, 2018
Merged

ci(travis): Node 11 (on OS X) crashes, use 10 for now #1588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Expand Up @@ -18,7 +18,9 @@ jobs:
stage: Test (MacOS)
os: 'osx'
env: SCRIPT=test
node_js: 'stable'
# Node 10 instead of 'stable' since Node 11 segfaults
# https://github.com/webpack/webpack-dev-server/pull/1588
node_js: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add comment here on issue 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a good idea I saw it a bit late :) But I also don't have the URL before actually creating the PR, so :D Will update once the test-run is done.

- <<: *osx
node_js: 'lts/*'
- <<: *osx
Expand Down