Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Server): Workaround for .wasm file mime type (#1575) #1580

Merged
merged 3 commits into from Dec 5, 2018

Conversation

samsam2310
Copy link
Contributor

@samsam2310 samsam2310 commented Nov 27, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes.

Motivation / Use-Case

fixes #1575

Breaking Changes

No

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Nov 27, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@alexander-akait
Copy link
Member

Please accept CLA

@samsam2310
Copy link
Contributor Author

I have accepted but the licence/cla seems still in pending ?

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #1580 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
+ Coverage   74.02%   74.06%   +0.03%     
==========================================
  Files          10       10              
  Lines         670      671       +1     
==========================================
+ Hits          496      497       +1     
  Misses        174      174
Impacted Files Coverage Δ
lib/Server.js 81.42% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3a257...c028b81. Read the comment docs.

@alexander-akait
Copy link
Member

@samsam2310 CLA sometimes buggy, will be shipped in near future

@odinho
Copy link
Contributor

odinho commented Dec 4, 2018

@samsam2310 If you rebase onto newest master, the Travis tests should pass.

This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get mime type "application/octet-stream" for wasm files
5 participants