fix: runOpen - made warning output related url

webpack · Oct 2, 2019 · df0384e · df0384e
1 parent c727994
commit df0384e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/utils/runOpen.js b/lib/utils/runOpen.js
@@ -6,11 +6,11 @@ const isAbsoluteUrl = require('is-absolute-url');
 function runOpen(uri, options, log) {
   // https://github.com/webpack/webpack-dev-server/issues/1990
   let openOptions = { wait: false };
-  let openMessage = 'Unable to open browser';
+  let openOptionValue = '';
 
   if (typeof options.open === 'string') {
     openOptions = Object.assign({}, openOptions, { app: options.open });
-    openMessage += `: ${options.open}`;
+    openOptionValue = `: ${options.open}`;
   }
 
   const pages =
@@ -24,7 +24,7 @@ function runOpen(uri, options, log) {
 
       return open(pageUrl, openOptions).catch(() => {
         log.warn(
-          `${openMessage}. If you are running in a headless environment, please do not use the --open flag`
+          `Unable to open ${pageUrl} in browser${openOptionValue}. If you are running in a headless environment, please do not use the --open flag`
         );
       });
     })

diff --git a/test/server/utils/runOpen.test.js b/test/server/utils/runOpen.test.js
@@ -181,7 +181,7 @@ describe('runOpen util', () => {
     it('on specify URL and log error', () => {
       return runOpen('https://example.com', {}, logMock).then(() => {
         expect(logMock.warn.mock.calls[0][0]).toMatchInlineSnapshot(
-          `"Unable to open browser. If you are running in a headless environment, please do not use the --open flag"`
+          `"Unable to open https://example.com in browser. If you are running in a headless environment, please do not use the --open flag"`
         );
         expect(opn.mock.calls[0]).toMatchInlineSnapshot(`
           Array [
@@ -201,7 +201,7 @@ describe('runOpen util', () => {
         logMock
       ).then(() => {
         expect(logMock.warn.mock.calls[0][0]).toMatchInlineSnapshot(
-          `"Unable to open browser. If you are running in a headless environment, please do not use the --open flag"`
+          `"Unable to open https://example.com/index.html in browser. If you are running in a headless environment, please do not use the --open flag"`
         );
         expect(opn.mock.calls[0]).toMatchInlineSnapshot(`
           Array [
@@ -221,7 +221,7 @@ describe('runOpen util', () => {
         logMock
       ).then(() => {
         expect(logMock.warn.mock.calls[0][0]).toMatchInlineSnapshot(
-          `"Unable to open browser: Google Chrome. If you are running in a headless environment, please do not use the --open flag"`
+          `"Unable to open https://example.com in browser: Google Chrome. If you are running in a headless environment, please do not use the --open flag"`
         );
         expect(opn.mock.calls[0]).toMatchInlineSnapshot(`
           Array [
@@ -242,7 +242,7 @@ describe('runOpen util', () => {
         logMock
       ).then(() => {
         expect(logMock.warn.mock.calls[0][0]).toMatchInlineSnapshot(
-          `"Unable to open browser: Google Chrome. If you are running in a headless environment, please do not use the --open flag"`
+          `"Unable to open https://example.com/index.html in browser: Google Chrome. If you are running in a headless environment, please do not use the --open flag"`
         );
         expect(opn.mock.calls[0]).toMatchInlineSnapshot(`
           Array [