fix(options): add writeToDisk option to schema (#1520)

webpack · Oct 10, 2018 · d2f4902 · d2f4902
1 parent bb484ad
commit d2f4902
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/options.json b/lib/options.json
@@ -54,6 +54,16 @@
     "watchOptions": {
       "type": "object"
     },
+    "writeToDisk": {
+      "anyOf": [
+        {
+          "type": "boolean"
+        },
+        {
+          "instanceof": "Function"
+        }
+      ]
+    },
     "headers": {
       "type": "object"
     },
@@ -312,6 +322,7 @@
       "port": "should be {String|Number} (https://webpack.js.org/configuration/dev-server/#devserver-port)",
       "socket": "should be {String} (https://webpack.js.org/configuration/dev-server/#devserver-socket)",
       "watchOptions": "should be {Object} (https://webpack.js.org/configuration/dev-server/#devserver-watchoptions)",
+      "writeToDisk": "should be {Boolean|Function} (https://github.com/webpack/webpack-dev-middleware#writetodisk)",
       "headers": "should be {Object} (https://webpack.js.org/configuration/dev-server/#devserver-headers-)",
       "clientLogLevel": "should be {String} and equal to one of the allowed values\n\n [ 'trace', 'debug', 'info', 'warn', 'error', 'silent' ]\n\n(https://webpack.js.org/configuration/dev-server/#devserver-clientloglevel)",
       "overlay": "should be {Object|Boolean} (https://webpack.js.org/configuration/dev-server/#devserver-overlay)",

diff --git a/test/Validation.test.js b/test/Validation.test.js
@@ -26,6 +26,11 @@ describe('Validation', () => {
       config: { logLevel: 1 },
       message: 'options.logLevel should be {String} and equal to one of the allowed values'
     },
+    {
+      name: 'invalid `writeToDisk` configuration',
+      config: { writeToDisk: 1 },
+      message: 'options.writeToDisk should be {Boolean|Function} (https://github.com/webpack/webpack-dev-middleware#writetodisk)\n'
+    },
     {
       name: 'invalid `overlay` configuration',
       config: { overlay: { errors: 1 } },