Skip to content

Commit

Permalink
chore(deps): update webpack to 4.39.0 (#2171)
Browse files Browse the repository at this point in the history
  • Loading branch information
hiroppy committed Aug 2, 2019
1 parent c2da532 commit 68a1f29
Show file tree
Hide file tree
Showing 4 changed files with 73 additions and 45 deletions.
102 changes: 63 additions & 39 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -110,7 +110,7 @@
"tcp-port-used": "^1.0.1",
"typescript": "^3.5.3",
"url-loader": "^1.1.2",
"webpack": "^4.38.0",
"webpack": "^4.39.0",
"webpack-cli": "^3.3.6"
},
"peerDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions test/cli/cli.test.js
Expand Up @@ -34,9 +34,9 @@ describe('CLI', () => {
.then((output) => {
expect(output.code).toEqual(0);
// should profile
expect(
output.stderr.includes('ms after chunk modules optimization')
).toBe(true);
expect(output.stderr.includes('after chunk modules optimization')).toBe(
true
);
done();
})
.catch(done);
Expand Down
8 changes: 6 additions & 2 deletions test/server/profile-option.test.js
Expand Up @@ -30,17 +30,21 @@ describe('profile', () => {
mockStderr.mockRestore();
let foundProgress = false;
let foundProfile = false;

calls.forEach((call) => {
if (call[0].includes('0% compiling')) {
const text = call[0];

if (text.includes('0% compiling')) {
foundProgress = true;
}

// this is an indicator that the profile option is enabled,
// so we should expect to find it in stderr since profile is enabled
if (call[0].includes('ms after chunk modules optimization')) {
if (text.includes('after chunk modules optimization')) {
foundProfile = true;
}
});

expect(foundProgress).toBeTruthy();
expect(foundProfile).toBeTruthy();

Expand Down

0 comments on commit 68a1f29

Please sign in to comment.