Skip to content

Commit

Permalink
test(server): add exit signal tests
Browse files Browse the repository at this point in the history
  • Loading branch information
knagaitsev committed Aug 7, 2019
1 parent 9ba22d5 commit 4d3637d
Show file tree
Hide file tree
Showing 2 changed files with 61 additions and 1 deletion.
5 changes: 4 additions & 1 deletion bin/webpack-dev-server.js
Expand Up @@ -22,7 +22,10 @@ let server;
const serverData = {
server: null,
};

// we must pass an object that contains the server object as a property so that
// we can update this server property later, and setupExitSignals will be able to
// recognize that the server has been instantiated, because we will set
// serverData.server to the new server object.
setupExitSignals(serverData);

// Prefer the local installation of webpack-dev-server
Expand Down
57 changes: 57 additions & 0 deletions test/server/utils/setupExitSignals.test.js
@@ -0,0 +1,57 @@
'use strict';

const setupExitSignals = require('../../../lib/utils/setupExitSignals');

describe('setupExitSignals', () => {
let server;
let exitSpy;
const signals = ['SIGINT', 'SIGTERM'];

beforeAll(() => {
exitSpy = jest.spyOn(process, 'exit').mockImplementation(() => { });
server = {
close: jest.fn((callback) => {
callback();
}),
};
});

afterEach(() => {
exitSpy.mockReset();
server.close.mockClear();
signals.forEach((signal) => {
process.removeAllListeners(signal);
});
});

signals.forEach((signal) => {
it(`should exit process (${signal}, server never defined)`, (done) => {
setupExitSignals({
server: null,
});
process.emit(signal);
setTimeout(() => {
expect(exitSpy.mock.calls.length).toEqual(1);
done();
}, 1000);
});

it(`should close server, then exit process (${signal}, server defined before signal)`, (done) => {
const serverData = {
server: null,
};
setupExitSignals(serverData);

setTimeout(() => {
serverData.server = server;
process.emit(signal);
}, 500);

setTimeout(() => {
expect(server.close.mock.calls.length).toEqual(1);
expect(exitSpy.mock.calls.length).toEqual(1);
done();
}, 1500);
});
});
});

0 comments on commit 4d3637d

Please sign in to comment.